BUGFIX EXTPLESK-8950 Fix case when getAll returns 1 database instead of 0#188
Merged
sibprogrammer merged 1 commit intoplesk:masterfrom Feb 10, 2026
Conversation
sibprogrammer
requested changes
Feb 3, 2026
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
619c2b3 to
73c3eeb
Compare
sibprogrammer
requested changes
Feb 4, 2026
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
73c3eeb to
c298f6f
Compare
sibprogrammer
requested changes
Feb 5, 2026
sibprogrammer
requested changes
Feb 5, 2026
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
c298f6f to
5166bc8
Compare
sibprogrammer
requested changes
Feb 10, 2026
tests/DatabaseTest.php
Outdated
|
|
||
| public function testGetAllForWebspaceWithNoDatabases() | ||
| { | ||
| $webspace = static::$webspace; |
Member
There was a problem hiding this comment.
There is no need for an additional variable if it's used only once on the next line. Just use it: static::$webspace->id
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=========================================
Coverage 91.49% 91.49%
- Complexity 434 436 +2
=========================================
Files 83 83
Lines 1411 1411
=========================================
Hits 1291 1291
Misses 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
whytea91
force-pushed
the
bugfix-correctly-fetch-current-databases-number
branch
from
5166bc8 to
f57322f
Compare
sibprogrammer
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no databases on a domain, the API returns:
However, the getAll method returns one object with empty values (because if ($xmlResult) is always true, even when there are no DBs).